9aman opened a new pull request, #15123:
URL: https://github.com/apache/pinot/pull/15123

   ## Issue
   GCS pinot FS returns `true` while trying to delete a directory/ file even 
when the directory/ file does not exist, when the forceDelete flag is set to 
`true`. 
   
   This behavior is **wrong** and is **different** from that of S3PinotFS and 
LocalPinotFS, that return false in case the directory/ file is missing 
irrespective of the forceDelete flag value.
   
   ## Fix
   
   Align GCSPinotFS for the case when the directory or file is missing i.e. 
return false for delete irrespective of the forceDelete flag
   
   ### Any impact on functionality of other functions of the interface ?
   This function is currently used by `doMove`. doMove ensures the existence of 
the file before performing the move from source to destination. The above 
change in delete should not impact it. 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to