gortiz commented on code in PR #15071:
URL: https://github.com/apache/pinot/pull/15071#discussion_r1963599082
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/OpChainSchedulerService.java:
##########
@@ -49,10 +49,9 @@ public void register(OpChain operatorChain) {
Future<?> scheduledFuture = _executorService.submit(new TraceRunnable() {
@Override
public void runJob() {
- boolean isFinished = false;
TransferableBlock returnedErrorBlock = null;
Throwable thrown = null;
- try {
+ try (OpChain closeMe = operatorChain) {
Review Comment:
That is a good idea. Ideally, we should try to refactor this code to make it
easier to understand.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
