swaminathanmanish commented on code in PR #15097:
URL: https://github.com/apache/pinot/pull/15097#discussion_r1963051287
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/writer/StatelessRealtimeSegmentWriter.java:
##########
@@ -345,36 +345,44 @@ public File buildSegment() {
} catch (InterruptedException e) {
throw new RuntimeException("Interrupted while waiting for segment build
semaphore", e);
}
- long lockAcquireTimeMs = now();
- _logger.info("Acquired lock for building segment in {} ms",
lockAcquireTimeMs - startTimeMs);
-
- // Build a segment from in-memory rows.
- SegmentZKPropsConfig segmentZKPropsConfig = new SegmentZKPropsConfig();
- segmentZKPropsConfig.setStartOffset(_startOffset.toString());
- segmentZKPropsConfig.setEndOffset(_endOffset.toString());
-
- // Build the segment
- RealtimeSegmentConverter converter =
- new RealtimeSegmentConverter(_realtimeSegment, segmentZKPropsConfig,
_resourceTmpDir.getAbsolutePath(), _schema,
- _tableNameWithType, _tableConfig,
_segmentZKMetadata.getSegmentName(),
- _tableConfig.getIndexingConfig().isNullHandlingEnabled());
try {
- converter.build(null, null);
- } catch (Exception e) {
- throw new RuntimeException("Failed to build segment", e);
- }
- _logger.info("Successfully built segment (Column Mode: {}) in {} ms",
converter.isColumnMajorEnabled(),
- now() - lockAcquireTimeMs);
+ long lockAcquireTimeMs = now();
+ _logger.info("Acquired lock for building segment in {} ms",
lockAcquireTimeMs - startTimeMs);
+
+ // Build a segment from in-memory rows.
+ SegmentZKPropsConfig segmentZKPropsConfig = new SegmentZKPropsConfig();
+ segmentZKPropsConfig.setStartOffset(_startOffset.toString());
+ segmentZKPropsConfig.setEndOffset(_endOffset.toString());
+
+ // Build the segment
+ RealtimeSegmentConverter converter =
+ new RealtimeSegmentConverter(_realtimeSegment, segmentZKPropsConfig,
_resourceTmpDir.getAbsolutePath(),
+ _schema,
+ _tableNameWithType, _tableConfig,
_segmentZKMetadata.getSegmentName(),
+ _tableConfig.getIndexingConfig().isNullHandlingEnabled());
+ try {
+ converter.build(null, null);
+ } catch (Exception e) {
+ throw new RuntimeException("Failed to build segment", e);
+ }
+ _logger.info("Successfully built segment (Column Mode: {}) in {} ms",
converter.isColumnMajorEnabled(),
+ now() - lockAcquireTimeMs);
- File indexDir = new File(_resourceTmpDir, _segmentName);
- File segmentTarFile = new File(_resourceTmpDir, _segmentName +
TarCompressionUtils.TAR_GZ_FILE_EXTENSION);
- try {
- TarCompressionUtils.createCompressedTarFile(new File(_resourceTmpDir,
_segmentName), segmentTarFile);
- } catch (Exception e) {
- throw new RuntimeException(
- "Caught exception while tarring index directory from: " + indexDir +
" to: " + segmentTarFile, e);
+ File indexDir = new File(_resourceTmpDir, _segmentName);
+ File segmentTarFile = new File(_resourceTmpDir, _segmentName +
TarCompressionUtils.TAR_GZ_FILE_EXTENSION);
+ try {
+ TarCompressionUtils.createCompressedTarFile(new File(_resourceTmpDir,
_segmentName), segmentTarFile);
+ } catch (Exception e) {
+ throw new RuntimeException(
+ "Caught exception while tarring index directory from: " + indexDir
+ " to: " + segmentTarFile, e);
+ }
+ return segmentTarFile;
+ } finally {
+ if (_segBuildSemaphore != null) {
Review Comment:
Please verify that we can do the ingestion post DR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
