suddendust commented on PR #13951:
URL: https://github.com/apache/pinot/pull/13951#issuecomment-2658895106

   @Jackie-Jiang For non-replica group based instance assignment, added a check 
in `InstancePartitionUtils.computeDefaultInstancePartitionsForTag`. For 
replica-group based assignment, rebalancing is necessary. Example:
   
   For a cluster with 4 DefaultTenant_OFFLINE servers, if I configure the 
following instance assignment (update the table config):
   
   ```
       "instanceAssignmentConfigMap": {
         "OFFLINE": {
           "tagPoolConfig": {
             "tag": "DefaultTenant_OFFLINE",
             "poolBased": false,
             "numPools": 0
           },
           "replicaGroupPartitionConfig": {
             "replicaGroupBased": true,
             "numInstances": 4,
             "numReplicaGroups": 4,
             "numInstancesPerReplicaGroup": 2,
             "numPartitions": 0,
             "numInstancesPerPartition": 0,
             "minimizeDataMovement": false
           },
           "partitionSelector": "INSTANCE_REPLICA_GROUP_PARTITION_SELECTOR",
           "minimizeDataMovement": false
         }
       }
   ```
   
   It lets us through. This is actually caught only when you rebalance the 
table.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to