9aman commented on code in PR #15008:
URL: https://github.com/apache/pinot/pull/15008#discussion_r1955631568
##########
pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java:
##########
@@ -299,6 +299,14 @@ private static long getRandomInitialDelayInSeconds() {
private static final String REALTIME_SEGMENT_METADATA_COMMIT_NUMLOCKS =
"controller.realtime.segment.metadata.commit.numLocks";
private static final String ENABLE_STORAGE_QUOTA_CHECK =
"controller.enable.storage.quota.check";
+ private static final String DISK_UTILIZATION_THRESHOLD =
"controller.disk.utilization.threshold";
Review Comment:
nit: Should we add a comment here stating that the value should be 0 <
threshold < 1.
I usually get confused whether I have to provide percentage or a double.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
