swaminathanmanish commented on code in PR #15008: URL: https://github.com/apache/pinot/pull/15008#discussion_r1952022692
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java: ########## @@ -641,6 +652,13 @@ protected TaskSchedulingInfo scheduleTask(PinotTaskGenerator taskGenerator, List for (TableConfig tableConfig : enabledTableConfigs) { String tableName = tableConfig.getTableName(); try { + if (!_resourceUtilizationManager.isResourceUtilizationWithinLimits(tableName)) { Review Comment: Its better we dont make any assumptions on task types. If the disk is nearing capacity, then we need to take action regardless. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org