somandal commented on PR #15029: URL: https://github.com/apache/pinot/pull/15029#issuecomment-2651679556
> I'm thinking still adding the pre-check into rebalance API, but when it is enabled, only perform the pre-check but not the rebalance itself, or it is too late and there is no way to stop the rebalance. Pre-check + dry-run should be okay. Yeah I can add checks to ensure that preCheck is only enabled with dryRun mode. I'll update the PR once that is ready. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org