swaminathanmanish commented on code in PR #15016:
URL: https://github.com/apache/pinot/pull/15016#discussion_r1948953700
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -611,6 +665,17 @@ protected void preProcessCommitSegmentEndMetadata() {
// No-op
}
+ private void updateCommittingSegmentsList(String realtimeTableName,
+ Callable<Boolean> operation) {
+ try {
+ DEFAULT_RETRY_POLICY.attempt(operation);
+ } catch (Exception e) {
+ _controllerMetrics.addMeteredTableValue(realtimeTableName,
ControllerMeter.LLC_ZOOKEEPER_UPDATE_FAILURES, 1L);
+ LOGGER.error("Failed to update committing segments list for table: {}",
realtimeTableName, e);
+ throw new RuntimeException(e);
Review Comment:
I think we can just log an error with the segment that needs to be committed
(in the committing list( and skip throwing the exception).
Yes there can be inconsistencies for the adds which we can't fix in
ValidationManager without going through all segment Zk metadata, but I guess it
should be ok.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
