somandal commented on PR #15001: URL: https://github.com/apache/pinot/pull/15001#issuecomment-2638353488
> Seems like the download throttling is on each table. Not introduced in this PR, but that is wrong. The semaphore needs to be passed from outside so that it can be shared across all tables. I think the original intention of this semaphore was to be a separate semaphore for each table (e.g. see the comments and docs related to this) itself, and passing it from outside as a shared semaphore across all tables will result in a big behavior change. For now I would like to keep the overall functionality the same. We can open an issue for consolidating these under a single semaphore or treating these as per table overridable configs perhaps (which was another idea I had discussed with @klsince). What do you think @Jackie-Jiang? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
