Jackie-Jiang commented on code in PR #14943:
URL: https://github.com/apache/pinot/pull/14943#discussion_r1943565452
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/BaseServerStarter.java:
##########
@@ -664,7 +680,8 @@ public void start()
} catch (Exception e) {
LOGGER.error("Failed to register DefaultClusterConfigChangeHandler as
the Helix ClusterConfigChangeListener", e);
}
-
_clusterConfigChangeHandler.registerClusterConfigChangeListener(_segmentPreprocessThrottler);
+
_clusterConfigChangeHandler.registerClusterConfigChangeListener(_segmentAllIndexPreprocessThrottler);
+
_clusterConfigChangeHandler.registerClusterConfigChangeListener(_segmentStarTreePreprocessThrottler);
Review Comment:
Suggest making the top level `_segmentPreprocessThrottler` a listener and
only register that. We can use the top level throttler to delegate the cluster
change callback
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
