Jackie-Jiang commented on code in PR #14982:
URL: https://github.com/apache/pinot/pull/14982#discussion_r1940316175
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -337,6 +340,14 @@ public void setErrorOnColumnBuildFailure(boolean
errorOnColumnBuildFailure) {
_errorOnColumnBuildFailure = errorOnColumnBuildFailure;
}
+ public void setEnablePreProcess(boolean enablePreProcess) {
+ _enableSegmentPreprocess = enablePreProcess;
+ }
+
+ public boolean isEnablePreProcess() {
+ return _enableSegmentPreprocess;
+ }
+
Review Comment:
Don't add them, and make the field final. `IndexLoadingConfig` shouldn't be
modified
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -83,6 +84,7 @@ public class IndexLoadingConfig {
private boolean _enableDefaultStarTree;
private Map<String, FieldIndexConfigs> _indexConfigsByColName = new
HashMap<>();
+
Review Comment:
(nit) Revert
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/IndexLoadingConfig.java:
##########
@@ -56,6 +56,7 @@ public class IndexLoadingConfig {
private final InstanceDataManagerConfig _instanceDataManagerConfig;
private final TableConfig _tableConfig;
private final Schema _schema;
+ private boolean _enableSegmentPreprocess = true;
Review Comment:
Suggest renaming it to `_skipSegmentPreprocess` so that the default is
`false`. Adding default true flag is error prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
