tibrewalpratik17 commented on code in PR #14945:
URL: https://github.com/apache/pinot/pull/14945#discussion_r1940030515
##########
pinot-plugins/pinot-timeseries-lang/pinot-timeseries-m3ql/src/main/java/org/apache/pinot/tsdb/m3ql/M3TimeSeriesPlanner.java:
##########
@@ -152,7 +156,11 @@ public BaseTimeSeriesPlanNode handleFetchNode(String
planId, List<String> tokens
Preconditions.checkNotNull(timeColumn, "Time column not set. Set via
time_col=");
Preconditions.checkNotNull(timeUnit, "Time unit not set. Set via
time_unit=");
Preconditions.checkNotNull(valueExpr, "Value expression not set. Set via
value=");
+ Map<String, String> queryOptions = new HashMap<>();
+ if (request.getNumGroupsLimit() > 0) {
+ queryOptions.put("numGroupsLimit",
Integer.toString(request.getNumGroupsLimit()));
Review Comment:
nit: can put "numGroupsLimit" in a constant class
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
