yashmayya commented on code in PR #14946:
URL: https://github.com/apache/pinot/pull/14946#discussion_r1935408022


##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/MultiStageBrokerRequestHandler.java:
##########
@@ -112,6 +118,7 @@ public MultiStageBrokerRequestHandler(PinotConfiguration 
config, String brokerId
         
CommonConstants.MultiStageQueryRunner.KEY_OF_MULTISTAGE_EXPLAIN_INCLUDE_SEGMENT_PLAN,
         
CommonConstants.MultiStageQueryRunner.DEFAULT_OF_MULTISTAGE_EXPLAIN_INCLUDE_SEGMENT_PLAN);
     _queryThrottler = queryThrottler;
+    _queryCompileExecutor = Executors.newCachedThreadPool(new 
NamedThreadFactory("query-compile-executor"));

Review Comment:
   Also, we're using Jersey's `ManagedAsync` annotation on the API resource 
methods that call these broker request handler methods. So they're being 
executed on threads from the Jersey managed internal executor service. If 
that's  a fixed thread pool, I suppose we could make ours similar as well but 
I'm not able to find more info about that one. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to