KKcorps commented on code in PR #14829:
URL: https://github.com/apache/pinot/pull/14829#discussion_r1935299626
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java:
##########
@@ -483,92 +489,34 @@ public void registerTaskGenerator(PinotTaskGenerator
taskGenerator) {
_taskGeneratorRegistry.registerTaskGenerator(taskGenerator);
}
- /**
- * Schedules tasks (all task types) for all tables.
- * It might be called from the non-leader controller.
- * Returns a map from the task type to the {@link TaskSchedulingInfo} of
tasks scheduled.
- */
- public synchronized Map<String, TaskSchedulingInfo>
scheduleAllTasksForAllTables(@Nullable String minionInstanceTag) {
Review Comment:
I would suggest rather than removing them add a @Deprecated annotation on
top, along with the method that they should be using. We can remove this in
next release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
