fx19880617 commented on a change in pull request #4397: Adding Support for
Kafka 2.0 Consumer
URL: https://github.com/apache/incubator-pinot/pull/4397#discussion_r307192841
##########
File path: pom.xml
##########
@@ -141,10 +141,22 @@
kafka dependency is still explicitly defined in pinot-integration-tests,
pinot-tools and pinot-perf pom files.
To change kafka connector dependency, we only need to update this version
number config.
TODO: figure out a way to inject kafka dependency instead of explicitly
setting the kafka module dependency -->
- <kafka.lib.version>0.9</kafka.lib.version>
+ <kafka.version>0.9</kafka.version>
</properties>
<profiles>
+ <profile>
Review comment:
This is to override `kafka.version` from `0.9` to `2.0`, so `pinot-tools`,
`pinot-perf`, `pinot-integration-tests` repo maven will resolve it with the
right dependency.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
