mcvsubbu commented on issue #4317: Support variable length Offline Dictionary Indexes for bytes, strings and maps to save on storage URL: https://github.com/apache/incubator-pinot/issues/4317#issuecomment-503243421 I am sure I am missing something, but I don't see why we should try to combine VarByteChunkReader into this logic. If we can take bay steps, at least we can avoid duplication between MutableOffheapByteArrayStore and whatever @buchireddy has implemented (haven't seen it yet, please point me to a PR). We can then look into how other classes can fold into a single base class.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
