xiaohui-sun commented on a change in pull request #4326: [TE] Clean up and
inject ThirdEye Credentials into SecurityContext
URL: https://github.com/apache/incubator-pinot/pull/4326#discussion_r294445323
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/auth/ThirdEyeCredentials.java
##########
@@ -42,15 +51,23 @@ public void setPassword(String password) {
this.password = password;
}
+ public String getToken() {
+ return token;
+ }
+
+ public void setToken(String token) {
+ this.token = token;
+ }
+
@Override
public boolean equals(Object o) {
if (this == o) {
return true;
}
- if (!(o instanceof Credentials)) {
+ if (!(o instanceof ThirdEyeCredentials)) {
return false;
}
- Credentials that = (Credentials) o;
+ ThirdEyeCredentials that = (ThirdEyeCredentials) o;
return Objects.equals(principal, that.principal) &&
Objects.equals(password, that.password);
Review comment:
Add token into comparison.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
