Jackie-Jiang commented on a change in pull request #4269: Add interface and implementations for the new segment assignment URL: https://github.com/apache/incubator-pinot/pull/4269#discussion_r292716361
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/SegmentAssignmentStrategyFactory.java ########## @@ -0,0 +1,57 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.assignment.segment; + +import org.apache.helix.HelixManager; +import org.apache.pinot.common.config.TableConfig; +import org.apache.pinot.common.utils.CommonConstants.Helix.TableType; + + +/** + * Factory for the {@link SegmentAssignmentStrategy}. + */ +public class SegmentAssignmentStrategyFactory { + private SegmentAssignmentStrategyFactory() { + } + + public enum Strategy { + BalanceNumSegmentAssignmentStrategy, ReplicaGroupSegmentAssignmentStrategy + } + + public static SegmentAssignmentStrategy getSegmentAssignmentStrategy(HelixManager helixManager, + TableConfig tableConfig) { + SegmentAssignmentStrategy segmentAssignmentStrategy; + if (Strategy.ReplicaGroupSegmentAssignmentStrategy.name() + .equalsIgnoreCase(tableConfig.getValidationConfig().getSegmentAssignmentStrategy())) { + if (tableConfig.getTableType() == TableType.OFFLINE) { + segmentAssignmentStrategy = new OfflineReplicaGroupSegmentAssignmentStrategy(); + } else { + segmentAssignmentStrategy = new RealtimeReplicaGroupSegmentAssignmentStrategy(); + } + } else { + if (tableConfig.getTableType() == TableType.OFFLINE) { + segmentAssignmentStrategy = new OfflineBalanceNumSegmentAssignmentStrategy(); + } else { + segmentAssignmentStrategy = new RealtimeBalanceNumSegmentAssignmentStrategy(); Review comment: For HLC you never need to assign segment. Everything is handled on the server side. If HLC table calls the segment assignment, it will throw exception. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
