snleee edited a comment on issue #4289: Cleaning up getTableName() for segment metadata URL: https://github.com/apache/incubator-pinot/pull/4289#issuecomment-500623323 > Can we mark segmentMetadata.getTableName() with @ deprecated? > > minor suggestions, other than that lgtm As we discussed offline, I will deprecate `tableName` from segment zk metadata, not from segment metadata with another pr.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
