codecov-io edited a comment on issue #4216: PQL -> SQL enhancement - phase 1 - new Pinot Query Struct URL: https://github.com/apache/incubator-pinot/pull/4216#issuecomment-493376612 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=h1) Report > Merging [#4216](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/32b32b3d3f7d3b28c5ce65b72619761b68f3a514?src=pr&el=desc) will **decrease** coverage by `2.47%`. > The diff coverage is `26.4%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4216 +/- ## ============================================ - Coverage 67.12% 64.64% -2.48% Complexity 20 20 ============================================ Files 1040 1050 +10 Lines 51628 54856 +3228 Branches 7232 7824 +592 ============================================ + Hits 34654 35464 +810 - Misses 14611 16906 +2295 - Partials 2363 2486 +123 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...e/pinot/pql/parsers/pql2/ast/PredicateAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9QcmVkaWNhdGVBc3ROb2RlLmphdmE=) | `50% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...che/pinot/common/request/HavingFilterQueryMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9IYXZpbmdGaWx0ZXJRdWVyeU1hcC5qYXZh) | `14.7% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/pinot/common/request/FilterQueryMap.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9GaWx0ZXJRdWVyeU1hcC5qYXZh) | `41.37% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...a/org/apache/pinot/common/request/QuerySource.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9RdWVyeVNvdXJjZS5qYXZh) | `35.54% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...rg/apache/pinot/common/request/FilterOperator.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9GaWx0ZXJPcGVyYXRvci5qYXZh) | `87.5% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...t/pql/parsers/pql2/ast/BooleanOperatorAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9Cb29sZWFuT3BlcmF0b3JBc3ROb2RlLmphdmE=) | `27.77% <0%> (-3.48%)` | `0 <0> (ø)` | | | [...che/pinot/common/response/ProcessingException.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVzcG9uc2UvUHJvY2Vzc2luZ0V4Y2VwdGlvbi5qYXZh) | `24.67% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/apache/pinot/common/request/AggregationInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9BZ2dyZWdhdGlvbkluZm8uamF2YQ==) | `32.71% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...apache/pinot/common/request/HavingFilterQuery.java](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9IYXZpbmdGaWx0ZXJRdWVyeS5qYXZh) | `11.6% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | ... and [81 more](https://codecov.io/gh/apache/incubator-pinot/pull/4216/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=footer). Last update [32b32b3...a4c273c](https://codecov.io/gh/apache/incubator-pinot/pull/4216?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
