npawar commented on a change in pull request #4278: Add
OfflineSegmentIntervalChecker to PeriodicTasksIntegrationTests
URL: https://github.com/apache/incubator-pinot/pull/4278#discussion_r290950123
##########
File path:
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerPeriodicTasksIntegrationTests.java
##########
@@ -472,7 +474,26 @@ public void
afterBrokerResourceValidationManagerTest(ITestContext context)
dropOfflineTable(table2);
}
- // TODO: tests for other ControllerPeriodicTasks (RetentionManager,
OfflineSegmentIntervalChecker, RealtimeSegmentValidationManager)
+ @Test
Review comment:
this new test is not conforming to the sequential tests nature described in
that comment. I think it is fine for your test, as you are not creating or
changing any states. But it would be good to mention that in the comment so as
to not confuse anyone
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
