Jackie-Jiang commented on a change in pull request #4270: skip the inverted
index generation
URL: https://github.com/apache/incubator-pinot/pull/4270#discussion_r290124753
##########
File path:
pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/SegmentColumnarIndexCreator.java
##########
@@ -158,7 +158,8 @@ public void init(SegmentGeneratorConfig
segmentCreationSpec, SegmentIndexCreatio
}
// Initialize inverted index creator
- if (invertedIndexColumns.contains(columnName)) {
+ // Skip creating inverted index if sorted; _invertedIndexCreatorMap is
also correctly populated for metadata writing
Review comment:
I don't quite follow the second part of the comment. "Skip creating inverted
index if sorted" is good enough IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
