codecov-io commented on issue #4269: Add interface and implementations for the new segment assignment URL: https://github.com/apache/incubator-pinot/pull/4269#issuecomment-497900364 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=h1) Report > Merging [#4269](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/22b56edc6cc17220a18675cc077e374bbabd8575?src=pr&el=desc) will **increase** coverage by `0.22%`. > The diff coverage is `80.51%`. [](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4269 +/- ## ============================================ + Coverage 67.13% 67.35% +0.22% Complexity 20 20 ============================================ Files 1041 1046 +5 Lines 51564 51832 +268 Branches 7229 7275 +46 ============================================ + Hits 34618 34912 +294 + Misses 14573 14536 -37 - Partials 2373 2384 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...helix/core/assignment/InstancePartitionsUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvSW5zdGFuY2VQYXJ0aXRpb25zVXRpbHMuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...ller/helix/core/assignment/InstancePartitions.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvSW5zdGFuY2VQYXJ0aXRpb25zLmphdmE=) | `41.37% <41.37%> (ø)` | `0 <0> (?)` | | | [...ment/segment/SegmentAssignmentStrategyFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9TZWdtZW50QXNzaWdubWVudFN0cmF0ZWd5RmFjdG9yeS5qYXZh) | `80% <80%> (ø)` | `0 <0> (?)` | | | [...main/java/org/apache/pinot/common/utils/Pairs.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvUGFpcnMuamF2YQ==) | `82.89% <84.61%> (+4.51%)` | `0 <0> (ø)` | :arrow_down: | | [...ent/segment/RealtimeSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZWFsdGltZVNlZ21lbnRBc3NpZ25tZW50U3RyYXRlZ3kuamF2YQ==) | `88.88% <88.88%> (ø)` | `0 <0> (?)` | | | [...ore/assignment/segment/SegmentAssignmentUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9TZWdtZW50QXNzaWdubWVudFV0aWxzLmphdmE=) | `92.85% <92.85%> (ø)` | `0 <0> (?)` | | | [...t/segment/BalanceNumSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9CYWxhbmNlTnVtU2VnbWVudEFzc2lnbm1lbnRTdHJhdGVneS5qYXZh) | `93.02% <93.02%> (ø)` | `0 <0> (?)` | | | [...segment/ReplicaGroupSegmentAssignmentStrategy.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL2Fzc2lnbm1lbnQvc2VnbWVudC9SZXBsaWNhR3JvdXBTZWdtZW50QXNzaWdubWVudFN0cmF0ZWd5LmphdmE=) | `93.27% <93.27%> (ø)` | `0 <0> (?)` | | | [...he/pinot/core/query/pruner/ValidSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9wcnVuZXIvVmFsaWRTZWdtZW50UHJ1bmVyLmphdmE=) | `57.14% <0%> (-28.58%)` | `0% <0%> (ø)` | | | [...ore/startree/v2/builder/BaseSingleTreeBuilder.java](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9zdGFydHJlZS92Mi9idWlsZGVyL0Jhc2VTaW5nbGVUcmVlQnVpbGRlci5qYXZh) | `90.52% <0%> (-4.74%)` | `0% <0%> (ø)` | | | ... and [77 more](https://codecov.io/gh/apache/incubator-pinot/pull/4269/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=footer). Last update [22b56ed...9877a44](https://codecov.io/gh/apache/incubator-pinot/pull/4269?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
