mcvsubbu commented on issue #4222: Add startup/shutdown checks for HelixServerStarter URL: https://github.com/apache/incubator-pinot/pull/4222#issuecomment-495409581 @Jackie-Jiang we don't need to implement the 'starting up' part at all. When the broker sends a query to the server, it can do one of: * send query response (either partial or complete) * send a boolean flag (or, an exception, not sure) saying it is shutting down. The broker can record this as if the server went off from externalview * timeout On startup, the broker can use the same logic as checking the EV change. Of course, we will need to account for the conditions where EV change can happen due to some other server (maybe broker should check instance config for 'isShuttingDown' before including a new server in the routing table).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
