npawar commented on issue #3998: Upgrade to use Kafka release 2.1.1 URL: https://github.com/apache/incubator-pinot/issues/3998#issuecomment-494917701 Had some discussion with @snleee @sunithabeeram and @mcvsubbu 1) For tests, we will let pinot-integration-tests have a dependency on pinot-kafka-0.9.0.1. No need to change those tests. For all other tests in pinot-core, pinot-common, pinot-controller, will clean those up to not depend on kafka (some simply are referring to class names), and use FakeStream if needed. 2) @snleee confirmed that we don't need to depend on kafka for Murmur PartitionFunction, and that function can be simply copied over. For ByteArrayPartitionFunction, we will either delete it, or translate the scala code. That way, we will remove kafka dependencies from PartitionFunction.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
