akshayrai commented on a change in pull request #4221: [TE] Code cleanup - Pull
out all validation checks from translator into validator modules
URL: https://github.com/apache/incubator-pinot/pull/4221#discussion_r285804479
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/validators/ConfigValidator.java
##########
@@ -29,17 +29,24 @@
*/
interface ConfigValidator<T extends AbstractDTO> {
/**
- * Validate the configuration. Thrown a validation exception if validation
failed.
+ * Validate the configuration
* @param config the config
- * @throws ValidationException the validation exception with error message
+ * @throws IllegalArgumentException exception with error message
*/
- void validateConfig(T config) throws ValidationException;
+ void validateConfig(T config) throws IllegalArgumentException;
/**
- * Validate the configuration. Thrown a validation exception if validation
failed.
+ * Validate the yaml configuration
+ * @param config the config
+ * @throws IllegalArgumentException exception with error message
+ */
+ void validateConfig(Map<String, Object> config) throws
IllegalArgumentException;
Review comment:
Updated!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
