kishoreg commented on a change in pull request #4216: PQL -> SQL enhancement -
phase 1 - new Pinot Query Struct
URL: https://github.com/apache/incubator-pinot/pull/4216#discussion_r285296638
##########
File path: pinot-common/src/thrift/request.thrift
##########
@@ -152,6 +153,7 @@ struct BrokerRequest {
14: optional map<string, string> queryOptions;
15: optional HavingFilterQuery havingFilterQuery;
16: optional HavingFilterQueryMap havingFilterSubQueryMap;
+ 17: optional query.PinotQuery pinotQuery;
Review comment:
separate endpoint is fine. Its more about how to change the execution layer.
BrokerRequest is used everywhere in the execution layer. Changing that to
pinotquery will be very invasive. Let me clone the issue from the fork and we
can discuss the high-level steps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
