Jackie-Jiang commented on a change in pull request #4218: Add
RealtimeConsumptionCatchupServiceCallback
URL: https://github.com/apache/incubator-pinot/pull/4218#discussion_r285292297
##########
File path:
pinot-common/src/main/java/org/apache/pinot/common/utils/ServiceStatus.java
##########
@@ -127,34 +129,129 @@ public String getStatusDescription() {
return statusDescription.toString();
}
}
+
+ public static abstract class BaseServiceStatusCallback implements
ServiceStatusCallback {
Review comment:
I don't think we need this base class. ServiceStatusCallback does not always
associate with Helix cluster info (e.g. MultipleCallbackServiceStatusCallback),
also the methods are not very commonly used. I don't like the way of returning
statusDescription by setting a member variable from the parent class, it's not
very readable. The base class IdealStateMatchServiceStatusCallback is already
good enough IMO.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
