akshayrai commented on a change in pull request #4217: [TE] distribute
detection and notification tasks
URL: https://github.com/apache/incubator-pinot/pull/4217#discussion_r285286018
##########
File path:
thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/alert/DetectionAlertTaskRunner.java
##########
@@ -107,13 +107,6 @@ private void
updateAlertConfigWatermarks(DetectionAlertFilterResult result, Dete
DetectionAlertFilter alertFilter =
detAlertTaskFactory.loadAlertFilter(alertConfig, System.currentTimeMillis());
DetectionAlertFilterResult result = alertFilter.run();
- // TODO: The old UI relies on notified tag to display the anomalies.
After the migration
- // we need to clean up all references to notified tag.
- for (MergedAnomalyResultDTO anomaly : result.getAllAnomalies()) {
Review comment:
There are many references to notified flag throughout the code. It is better
if we keep this comment and remove all references cleanly in a separate PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
