sunithabeeram opened a new pull request #4191: Randomly choose segments that need to be moved URL: https://github.com/apache/incubator-pinot/pull/4191 *Motivation* We have observed that with ReplicaGroupRebalanceStrategy, when a server has more segments, the segments that get moved off the server tend to be older segments that get retained out (due to inherent ordering of segments). This results in imbalance once retention-manager runs as the servers that had fewer segments will end up with fewer segments yet again. This change simply randomizes the segments before the choice of segments to move is made to ensure that segments moved are a mix of old and new ones. *Testing done* Existing tests pass; they validate the properties that the strategy need to adhere to.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
