mcvsubbu commented on a change in pull request #4047: Create leadControllerResource in helix cluster URL: https://github.com/apache/incubator-pinot/pull/4047#discussion_r273624778
########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/ControllerConf.java ########## @@ -58,6 +57,8 @@ private static final String CONSOLE_WEBAPP_USE_HTTPS = "controller.query.console.useHttps"; private static final String EXTERNAL_VIEW_ONLINE_TO_OFFLINE_TIMEOUT = "controller.upload.onlineToOfflineTimeout"; private static final String CONTROLLER_MODE = "controller.mode"; + private static final String NUMBER_OF_CONTROLLER_REPLICAS = "controller.number.replicas"; Review comment: I suggest we just set the number of replicas to 3 now, and not make it configurable. We can add configuration later if we see the need for it. Even making it 2 should be ok with rolling upgrades, but perhaps 3 is better. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
