mcvsubbu commented on a change in pull request #4089: In HelixBrokerStarter,
allow custom cluster change handlers
URL: https://github.com/apache/incubator-pinot/pull/4089#discussion_r273313954
##########
File path:
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/HelixBrokerStarter.java
##########
@@ -226,6 +232,45 @@ public void run() {
return brokerServerBuilder;
}
+ /**
+ * To be overridden to plug in custom external view change handlers.
+ * <p>NOTE: all change handlers will be run in a single thread, so any slow
change handler can block other change
+ * handlers from running. For slow change handler, make it asynchronous.
+ *
+ * @param spectatorHelixManager Spectator Helix manager
+ * @return List of custom external view change handlers to plug in
+ */
+ @SuppressWarnings("unused")
+ protected List<ClusterChangeHandler>
getCustomExternalViewChangeHandlers(HelixManager spectatorHelixManager) {
Review comment:
Why not inject configuration for class names and instantiate them through a
factory like we do for other such classes?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
