[incubator-pinot] branch master updated: [TE] detection - add more logs for merger for debugging (#3540)

[apucher]

This is an automated email from the ASF dual-hosted git repository.

apucher pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new ce6a53f  [TE] detection - add more logs for merger for debugging 
(#3540)
ce6a53f is described below

commit ce6a53fac7882badeef45deac3407d33e331416f
Author: Xiaohui Sun <xh...@linkedin.com>
AuthorDate: Mon Nov 26 10:14:07 2018 -0800

    [TE] detection - add more logs for merger for debugging (#3540)
---
 .../thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java     | 10 +++++++++-
 .../thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java         |  5 ++++-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git 
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
 
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
index ca97464..9e8ca0e 100644
--- 
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
+++ 
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/AnomalyTimeBasedSummarizer.java
@@ -86,6 +86,7 @@ public abstract class AnomalyTimeBasedSummarizer {
 
     for (int i = 0; i < anomalies.size(); i++) {
       AnomalyResult currentResult = anomalies.get(i);
+      LOG.info("Current anomaly start =[{}], end = [{}].", 
currentResult.getStartTime(), currentResult.getEndTime());
       if (mergedAnomaly == null || currentResult.getEndTime() < 
mergedAnomaly.getStartTime()) {
         mergedAnomaly = new MergedAnomalyResultDTO(currentResult);
       } else {
@@ -122,7 +123,14 @@ public abstract class AnomalyTimeBasedSummarizer {
         mergedAnomalies.add(mergedAnomaly);
       }
     }
-    LOG.info("merging [{}] raw anomalies", anomalies.size());
+
+    if (mergedAnomaly != null) {
+      LOG.info("merging [{}] raw anomalies, latest merged anomaly start =[{}], 
end = [{}], merged anomalies size [{}]",
+          anomalies.size(), mergedAnomaly.getStartTime(), 
mergedAnomaly.getEndTime(), mergedAnomalies.size());
+    } else {
+      LOG.info("merging [{}] raw anomalies", anomalies.size());
+    }
+
     return mergedAnomalies;
   }
 
diff --git 
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
 
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
index 6807af8..3b8170e 100644
--- 
a/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
+++ 
b/thirdeye/thirdeye-pinot/src/main/java/com/linkedin/thirdeye/anomaly/merge/TimeBasedAnomalyMerger.java
@@ -185,7 +185,10 @@ public class TimeBasedAnomalyMerger {
       MergedAnomalyResultDTO latestOverlappedMergedResult =
           
mergedResultDAO.findLatestOverlapByFunctionIdDimensions(function.getId(), 
dimensionMap.toString(),
               anomalyWindowStart - mergeConfig.getSequentialAllowedGap(), 
anomalyWindowEnd);
-
+      if (latestOverlappedMergedResult != null) {
+        LOG.info("Fetched anomaly id [{}] from time window start = [{}], end = 
[{}]", latestOverlappedMergedResult.getId(),
+            anomalyWindowStart - mergeConfig.getSequentialAllowedGap(), 
anomalyWindowEnd);
+      }
       List<MergedAnomalyResultDTO> mergedResults =
           
AnomalyTimeBasedSummarizer.mergeAnomalies(latestOverlappedMergedResult, 
unmergedResultsByDimensions,
               mergeConfig);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org