This is an automated email from the ASF dual-hosted git repository.
adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new d81e7345832 HDDS-14251. Fix missing putObjectAcl latency metrics in S3
gateway (#9563)
d81e7345832 is described below
commit d81e7345832d4d6cbd960a00a5611ef0043d5546
Author: KUAN-HAO HUANG <[email protected]>
AuthorDate: Sat Dec 27 16:04:03 2025 +0800
HDDS-14251. Fix missing putObjectAcl latency metrics in S3 gateway (#9563)
---
.../org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java | 2 ++
.../apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java | 11 +++++++++++
2 files changed, 13 insertions(+)
diff --git
a/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java
b/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java
index 15c1c58b496..5bb2c2952a3 100644
---
a/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java
+++
b/hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/metrics/S3GatewayMetrics.java
@@ -422,7 +422,9 @@ public void getMetrics(MetricsCollector collector, boolean
all) {
deleteObjectTaggingFailure.snapshot(recordBuilder, true);
deleteObjectTaggingFailureLatencyNs.snapshot(recordBuilder, true);
putObjectAclSuccess.snapshot(recordBuilder, true);
+ putObjectAclSuccessLatencyNs.snapshot(recordBuilder, true);
putObjectAclFailure.snapshot(recordBuilder, true);
+ putObjectAclFailureLatencyNs.snapshot(recordBuilder, true);
}
// INC and UPDATE
diff --git
a/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java
b/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java
index bfc471e22d5..7cbbf618657 100644
---
a/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java
+++
b/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/metrics/TestS3GatewayMetrics.java
@@ -39,6 +39,7 @@
import javax.ws.rs.core.HttpHeaders;
import javax.ws.rs.core.Response;
import javax.ws.rs.core.StreamingOutput;
+import org.apache.hadoop.metrics2.impl.MetricsCollectorImpl;
import org.apache.hadoop.ozone.OzoneConsts;
import org.apache.hadoop.ozone.client.OzoneBucket;
import org.apache.hadoop.ozone.client.OzoneClient;
@@ -659,4 +660,14 @@ private static InputStream getPutTaggingBody() {
return new ByteArrayInputStream(xml.getBytes(UTF_8));
}
+
+ @Test
+ public void testPutObjectAclLatencyMetricsSnapshot() {
+ MetricsCollectorImpl collector = new MetricsCollectorImpl();
+ metrics.getMetrics(collector, true);
+ String metricsString = collector.getRecords().toString();
+ assertThat(metricsString)
+ .contains("PutObjectAclSuccessLatencyNs")
+ .contains("PutObjectAclFailureLatencyNs");
+ }
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
