This is an automated email from the ASF dual-hosted git repository.

swamirishi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 074094262dc HDDS-14152. CodecBufferCodec should implement 
fromCodecBuffer deserialization method (#9480)
074094262dc is described below

commit 074094262dcd094a09ece2dacb5076a593728069
Author: Swaminathan Balachandran <[email protected]>
AuthorDate: Thu Dec 11 18:00:18 2025 -0500

    HDDS-14152. CodecBufferCodec should implement fromCodecBuffer 
deserialization method (#9480)
---
 .../hadoop/hdds/utils/db/CodecBufferCodec.java     |  5 ++
 .../hadoop/hdds/utils/db/TestCodecBufferCodec.java | 53 ++++++++++++++++++++++
 2 files changed, 58 insertions(+)

diff --git 
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/CodecBufferCodec.java
 
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/CodecBufferCodec.java
index 847e96adc81..9d2944fab66 100644
--- 
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/CodecBufferCodec.java
+++ 
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/CodecBufferCodec.java
@@ -60,6 +60,11 @@ public CodecBuffer toCodecBuffer(@Nonnull CodecBuffer 
object, CodecBuffer.Alloca
     return object;
   }
 
+  @Override
+  public CodecBuffer fromCodecBuffer(@Nonnull CodecBuffer buffer) {
+    return buffer;
+  }
+
   @Override
   public boolean supportCodecBuffer() {
     return true;
diff --git 
a/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestCodecBufferCodec.java
 
b/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestCodecBufferCodec.java
new file mode 100644
index 00000000000..03a2bc4f4ba
--- /dev/null
+++ 
b/hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/utils/db/TestCodecBufferCodec.java
@@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.hdds.utils.db;
+
+import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertSame;
+
+import org.junit.jupiter.params.ParameterizedTest;
+import org.junit.jupiter.params.provider.ValueSource;
+
+/**
+ * Test class for CodecBufferCodec.
+ */
+public class TestCodecBufferCodec {
+
+  @ParameterizedTest
+  @ValueSource(booleans = {true, false})
+  public void testFromCodecBufferMethod(boolean direct) throws CodecException {
+    Codec<CodecBuffer> codecBufferCodec = CodecBufferCodec.get(direct);
+    try (CodecBuffer codecBuffer = CodecBuffer.allocateDirect(10)) {
+      CodecBuffer value = codecBufferCodec.fromCodecBuffer(codecBuffer);
+      assertSame(codecBuffer, value);
+    }
+  }
+
+  @ParameterizedTest
+  @ValueSource(booleans = {true, false})
+  public void testFromPersistedFormat(boolean direct) throws CodecException {
+    Codec<CodecBuffer> codecBufferCodec = CodecBufferCodec.get(direct);
+    String testString = "Test123";
+    byte[] bytes = StringCodec.get().toPersistedFormat(testString);
+
+    try (CodecBuffer codecBuffer = 
codecBufferCodec.fromPersistedFormat(bytes)) {
+      String value = StringCodec.get().fromCodecBuffer(codecBuffer);
+      assertEquals(testString, value);
+    }
+  }
+}


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to