This is an automated email from the ASF dual-hosted git repository.

swamirishi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 9bb1898c576 HDDS-13957. Snapshot needsDefrag should be set on upgrade 
when creating missing yaml files (#9321)
9bb1898c576 is described below

commit 9bb1898c576f85d8b0e150a0be29b291bf3b949a
Author: Swaminathan Balachandran <[email protected]>
AuthorDate: Tue Nov 18 08:53:12 2025 -0500

    HDDS-13957. Snapshot needsDefrag should be set on upgrade when creating 
missing yaml files (#9321)
---
 .../apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java    | 3 +++
 .../hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java       | 2 ++
 2 files changed, 5 insertions(+)

diff --git 
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java
 
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java
index 10e296a2c85..be2a6706049 100644
--- 
a/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java
+++ 
b/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/OmSnapshotLocalDataManager.java
@@ -273,6 +273,9 @@ private void addMissingSnapshotYamlFiles(
           }
           OmSnapshotLocalData snapshotLocalData = new 
OmSnapshotLocalData(snapshotId, sstList,
               snapshotInfo.getPathPreviousSnapshotId(), null);
+          // Set needsDefrag to true to indicate that the snapshot needs to be 
defragmented, since the snapshot has
+          // never been defragmented before.
+          snapshotLocalData.setNeedsDefrag(true);
           snapshotLocalDataSerializer.save(snapshotLocalDataFile, 
snapshotLocalData);
         }
       }
diff --git 
a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java
 
b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java
index fff40480364..6e804f330ae 100644
--- 
a/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java
+++ 
b/hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOmSnapshotLocalDataManager.java
@@ -1012,6 +1012,8 @@ public void testInitWithMissingYamlFiles(boolean 
needsUpgrade) throws IOExceptio
           assertEquals(snapshotId, snapshotLocalData.getSnapshotId());
           assertEquals(previousMap.get(snapshotId), 
snapshotLocalData.getPreviousSnapshotId());
           assertEquals(expectedSstFile.get(snapshotId), 
snapshotLocalData.getVersionSstFileInfos());
+          assertTrue(readableOmSnapshotLocalDataProvider.needsDefrag());
+          assertTrue(snapshotLocalData.getNeedsDefrag());
         }
       }
     } else {


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to