This is an automated email from the ASF dual-hosted git repository.
agupta pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/master by this push:
new 75902681be HDDS-13079. Improve logging in DN for delete operation.
(#8489)
75902681be is described below
commit 75902681be0a3888a365a35ce52443827404adf4
Author: Ashish Kumar <[email protected]>
AuthorDate: Wed May 21 00:41:05 2025 +0530
HDDS-13079. Improve logging in DN for delete operation. (#8489)
---
.../statemachine/commandhandler/DeleteBlocksCommandHandler.java | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java
index 853c1dc622..9d28241df0 100644
---
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java
+++
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/statemachine/commandhandler/DeleteBlocksCommandHandler.java
@@ -381,7 +381,7 @@ private void processCmd(DeleteCmdInfo cmd) {
// Send ACK back to SCM as long as meta updated
// TODO Or we should wait until the blocks are actually deleted?
if (!containerBlocks.isEmpty()) {
- LOG.debug("Sending following block deletion ACK to SCM");
+ int successCount = 0, failedCount = 0;
for (DeleteBlockTransactionResult result :
blockDeletionACK.getResultsList()) {
boolean success = result.getSuccess();
@@ -392,11 +392,15 @@ private void processCmd(DeleteCmdInfo cmd) {
}
if (success) {
+ ++successCount;
blockDeleteMetrics.incrProcessedTransactionSuccessCount(1);
} else {
+ ++failedCount;
blockDeleteMetrics.incrProcessedTransactionFailCount(1);
}
}
+ LOG.info("Sending deletion ACK to SCM, successTransactionCount = {}," +
+ "failedTransactionCount= {}", successCount, failedCount);
}
cmdExecuted = true;
} finally {
@@ -648,7 +652,7 @@ public static boolean isDuplicateTransaction(long
containerId, KeyValueContainer
if (metrics != null) {
metrics.incOutOfOrderDeleteBlockTransactionCount();
}
- LOG.info(String.format("Delete blocks for containerId: %d"
+ LOG.debug(String.format("Delete blocks for containerId: %d"
+ " is received out of order, %d < %d", containerId,
delTX.getTxID(),
containerData.getDeleteTransactionId()));
} else if (delTX.getTxID() == containerData.getDeleteTransactionId()) {
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
