This is an automated email from the ASF dual-hosted git repository.
sammichen pushed a commit to branch HDDS-5713
in repository https://gitbox.apache.org/repos/asf/ozone.git
The following commit(s) were added to refs/heads/HDDS-5713 by this push:
new ddaeefbd64 HDDS-12567. [DiskBalancer] Log success container move
action (#8165)
ddaeefbd64 is described below
commit ddaeefbd64780c287cfa62c584b536a118e81295
Author: Gargi Jaiswal <[email protected]>
AuthorDate: Fri Mar 28 08:18:03 2025 +0530
HDDS-12567. [DiskBalancer] Log success container move action (#8165)
---
.../container/common/utils/ContainerLogger.java | 25 ++++++++++++++++++++++
.../diskbalancer/DiskBalancerService.java | 3 +++
2 files changed, 28 insertions(+)
diff --git
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
index 13692e4d82..69a5c1c3df 100644
---
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
+++
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/utils/ContainerLogger.java
@@ -21,6 +21,7 @@
import com.google.common.annotations.VisibleForTesting;
import org.apache.hadoop.ozone.container.common.impl.ContainerData;
+import org.apache.hadoop.ozone.container.common.volume.StorageVolume;
import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
@@ -149,6 +150,20 @@ public static void logRecovered(ContainerData
containerData) {
LOG.info(getMessage(containerData));
}
+ /**
+ * Logged when a container is successfully moved from one data volume to
another.
+ *
+ * @param containerId The ID of the moved container.
+ * @param sourceVolume The source volume path.
+ * @param destinationVolume The destination volume path.
+ * @param containerSize The size of data moved from container in bytes.
+ * @param timeTaken The time taken for the move in milliseconds.
+ */
+ public static void logMoveSuccess(long containerId, StorageVolume
sourceVolume,
+ StorageVolume destinationVolume, long containerSize, long timeTaken) {
+ LOG.info(getMessage(containerId, sourceVolume, destinationVolume,
containerSize, timeTaken));
+ }
+
private static String getMessage(ContainerData containerData,
String message) {
return String.join(FIELD_SEPARATOR, getMessage(containerData), message);
@@ -161,4 +176,14 @@ private static String getMessage(ContainerData
containerData) {
"BCSID=" + containerData.getBlockCommitSequenceId(),
"State=" + containerData.getState());
}
+
+ private static String getMessage(long containerId, StorageVolume
sourceVolume,
+ StorageVolume destinationVolume, long containerSize, long timeTaken) {
+ return String.join(FIELD_SEPARATOR,
+ "ID=" + containerId,
+ "SrcVolume=" + sourceVolume,
+ "DestVolume=" + destinationVolume,
+ "Size=" + containerSize + " bytes",
+ "TimeTaken=" + timeTaken + " ms");
+ }
}
diff --git
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
index 5bad084835..d84d8cf72c 100644
---
a/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
+++
b/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java
@@ -48,6 +48,7 @@
import org.apache.hadoop.ozone.container.common.impl.ContainerData;
import org.apache.hadoop.ozone.container.common.impl.ContainerDataYaml;
import org.apache.hadoop.ozone.container.common.interfaces.Container;
+import org.apache.hadoop.ozone.container.common.utils.ContainerLogger;
import org.apache.hadoop.ozone.container.common.utils.StorageVolumeUtil;
import org.apache.hadoop.ozone.container.common.volume.HddsVolume;
import org.apache.hadoop.ozone.container.common.volume.MutableVolumeSet;
@@ -485,6 +486,8 @@ public BackgroundTaskResult call() {
long endTime = Time.monotonicNow();
if (moveSucceeded) {
metrics.getMoveSuccessTime().add(endTime - startTime);
+ ContainerLogger.logMoveSuccess(containerId, sourceVolume,
+ destVolume, containerSize, endTime - startTime);
} else {
metrics.getMoveFailureTime().add(endTime - startTime);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
