This is an automated email from the ASF dual-hosted git repository.

adoroszlai pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ozone.git


The following commit(s) were added to refs/heads/master by this push:
     new 6b3226f76e HDDS-11125. Do not log user-controlled data in 
HddsConfServlet (#7767)
6b3226f76e is described below

commit 6b3226f76ee638fef2cb4c0d433e457c411423eb
Author: len548 <[email protected]>
AuthorDate: Tue Jan 28 21:01:10 2025 +0100

    HDDS-11125. Do not log user-controlled data in HddsConfServlet (#7767)
---
 .../main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java   | 9 ---------
 1 file changed, 9 deletions(-)

diff --git 
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
 
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
index ae52140248..788bcc29f7 100644
--- 
a/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
+++ 
b/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/conf/HddsConfServlet.java
@@ -34,8 +34,6 @@
 import org.apache.hadoop.hdds.server.http.HttpServer2;
 
 import com.google.common.annotations.VisibleForTesting;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
 
 /**
  * A servlet to print out the running configuration data.
@@ -51,9 +49,6 @@ public class HddsConfServlet extends HttpServlet {
   private static final String COMMAND = "cmd";
   private static final OzoneConfiguration OZONE_CONFIG =
       new OzoneConfiguration();
-  private static final transient Logger LOG =
-      LoggerFactory.getLogger(HddsConfServlet.class);
-
 
   /**
    * Return the Configuration of the daemon hosting this servlet.
@@ -162,10 +157,6 @@ private void processConfigTagRequest(HttpServletRequest 
request, String cmd,
         if (config.isPropertyTag(tag)) {
           Properties properties = config.getAllPropertiesByTag(tag);
           propMap.put(tag, properties);
-        } else {
-          if (LOG.isDebugEnabled()) {
-            LOG.debug("Not a valid tag {}", tag);
-          }
         }
       }
       out.write(JsonUtils.toJsonString(propMap));


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to