(ofbiz-framework) branch trunk updated: Improved: [optimization] There are several locations where in the loop we can exit early (OFBIZ-13319) #925

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9139c41ae3 Improved: [optimization] There are several locations where 
in the loop we can exit early (OFBIZ-13319) #925
9139c41ae3 is described below

commit 9139c41ae35bdf0834761d9ccf4862a90485828e
Author: Dmitry Kryukov <d...@users.noreply.github.com>
AuthorDate: Sat Nov 29 17:43:44 2025 +0300

    Improved: [optimization] There are several locations where in the loop we 
can exit early (OFBIZ-13319) #925
    
    It concerns loops where the only action is searching for match.
    For example:
                    for (String packageFilter : packageFilterSet) {
                        if (packageName.contains(packageFilter)) {
                            foundMatch = true;
                            break; // to be added
                        }
                    }
    
    Thanks: Dmitriy Kryukov
    
    Signed-off-by: Dmitry Kryukov <d...@ya.ru>
---
 .../main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java    | 2 ++
 .../entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java | 1 +
 .../src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java   | 1 +
 3 files changed, 4 insertions(+)

diff --git 
a/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java
 
b/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java
index cf36b3cb7d..08f4aca97d 100644
--- 
a/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java
+++ 
b/applications/product/src/main/java/org/apache/ofbiz/product/store/ProductStoreWorker.java
@@ -293,6 +293,7 @@ public final class ProductStoreWorker {
                         for (BigDecimal size: itemSizes) {
                             if (size.compareTo(minSize) < 0) {
                                 allMatch = false;
+                                break;
                             }
                         }
                     }
@@ -308,6 +309,7 @@ public final class ProductStoreWorker {
                         for (BigDecimal size: itemSizes) {
                             if (size.compareTo(maxSize) > 0) {
                                 allMatch = false;
+                                break;
                             }
                         }
                     }
diff --git 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java
index 5bfb0f23c2..afd0a14c46 100644
--- 
a/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java
+++ 
b/framework/entity/src/main/java/org/apache/ofbiz/entity/model/ModelReader.java
@@ -577,6 +577,7 @@ public final class ModelReader implements Serializable {
                 for (String packageFilter : packageFilterSet) {
                     if (packageName.contains(packageFilter)) {
                         foundMatch = true;
+                        break;
                     }
                 }
                 if (!foundMatch) {
diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
index 1f4f23bfa2..e94c3f43f8 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/RequestHandler.java
@@ -635,6 +635,7 @@ public final class RequestHandler {
             for (int i = 0; i < loginUris.length; i++) {
                 if (requestUri.equals(loginUris[i])) {
                     removePreviousRequest = false;
+                    break;
                 }
             }
             if (removePreviousRequest) {