This is an automated email from the ASF dual-hosted git repository.
deepak pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/trunk by this push:
new f71906c362 Fixed issue where include-form tag failed when referencing
a grid (OFBIZ-13290)
f71906c362 is described below
commit f71906c362f2f000faed80a513060cc073791126
Author: Deepak Dixit <[email protected]>
AuthorDate: Sat Sep 6 15:49:18 2025 +0530
Fixed issue where include-form tag failed when referencing a grid
(OFBIZ-13290)
---
.../src/main/java/org/apache/ofbiz/widget/model/FormFactory.java | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/FormFactory.java
b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/FormFactory.java
index 2a7e8f351a..81ca151694 100644
---
a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/FormFactory.java
+++
b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/FormFactory.java
@@ -146,13 +146,20 @@ public class FormFactory {
rootElement = UtilXml.firstChildElement(rootElement, "forms");
}
Element formElement = UtilXml.firstChildElement(rootElement, "form",
"name", formName);
+ if (formElement == null) {
+ // look for grid definition
+ formElement = UtilXml.firstChildElement(rootElement, "grid",
"name", formName);
+ }
+ if (formElement == null) {
+ throw new IllegalArgumentException("Could not find form with name
[" + formName + "] in class resource [" + formLocation + "]");
+ }
return createModelForm(formElement, entityModelReader, visualTheme,
dispatchContext, formLocation, formName);
}
public static ModelForm createModelForm(Element formElement, ModelReader
entityModelReader, VisualTheme visualTheme,
DispatchContext dispatchContext,
String formLocation, String formName) {
String formType = formElement.getAttribute("type");
- if (formType.isEmpty() || "single".equals(formType) ||
"upload".equals(formType)) {
+ if ("form".equals(formElement.getTagName()) && (formType.isEmpty() ||
"single".equals(formType) || "upload".equals(formType))) {
return new ModelSingleForm(formElement, formLocation,
entityModelReader, visualTheme, dispatchContext);
}
return new ModelGrid(formElement, formLocation, entityModelReader,
visualTheme, dispatchContext);