This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit 7bdf4b5c925f41610f5c81bf3773b93efff168cb
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Mon Oct 28 12:08:09 2024 +0100
Improved: Fix some bugs SpotBugs reports (OFBIZ-12386)
After https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=33fc03fa10
I thought the problem was fixed since it's excluded. But it was not because
there was a typo (a trailing blank in
<Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR " />)
So I fixed that, but to my surprise it still does not work, weird :/
---
spotbugs/exclude.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/spotbugs/exclude.xml b/spotbugs/exclude.xml
index ec37597473..bd57d274fa 100644
--- a/spotbugs/exclude.xml
+++ b/spotbugs/exclude.xml
@@ -193,9 +193,9 @@ under the License.
<Bug pattern="EQ_CHECK_FOR_OPERAND_NOT_COMPATIBLE_WITH_THIS" />
</Match><!-- ^ ^ not a problem, false positives -->
<Match>
- <!-- As it's also used by WebAppCacheTest class I made it package. That's
safer but not enough so it's also here -->
+ <!-- As it's also used by WebAppCacheTest class I made it package. That's
safer but not enough as private so it's here -->
<Class name="org.apache.ofbiz.webapp.WebAppCache" />
<Method name="WebAppCache" />
- <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR " />
+ <Bug pattern="SING_SINGLETON_HAS_NONPRIVATE_CONSTRUCTOR" />
</Match>
</FindBugsFilter>
