This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit cb8c65124bca100b109f3cd1f7008a32239f3255
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Sun May 19 10:40:58 2024 +0200

    Fixed: The non ASCII language in UiLabels.xml are not correctly handled 
during plugin creation  (OFBIZ-13095)
    
    You get this error:
    
    2024-05-19 09:52:41,314 |jsse-nio-8443-exec-3 |UtilProperties |W| XML file 
for
    locale could not be loaded.
    org.xml.sax.SAXParseException: Invalid byte 3 of 3-byte UTF-8 sequence.
    
    When removing ZH labels it works. We should keep only English languages or
    amend the createPlugin Gradle task. In this commit I remove all non English
    labels and put a comment as documentation about that for developers
    in framework/resources/templates/UiLabels.xml
---
 framework/resources/templates/UiLabels.xml | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/framework/resources/templates/UiLabels.xml 
b/framework/resources/templates/UiLabels.xml
index b34d2142c7..c6b869a2e0 100644
--- a/framework/resources/templates/UiLabels.xml
+++ b/framework/resources/templates/UiLabels.xml
@@ -18,25 +18,19 @@ specific language governing permissions and limitations
 under the License.
 -->
 
+<!-- Keep only English language here because of OFBIZ-13095 -->
+
 <resource xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; 
xsi:noNamespaceSchemaLocation="https://ofbiz.apache.org/dtds/ofbiz-properties.xsd";>
     <property key="@component-resource-name@Application">
         <value xml:lang="en">@component-resource-name@ Application</value>
-        <value xml:lang="zh">@component-resource-name@应用程序</value>
-        <value xml:lang="zh-TW">@component-resource-name@應用程式</value>
     </property>
     <property key="@component-resource-name@CompanyName">
         <value xml:lang="en">OFBiz: @component-resource-name@</value>
-        <value xml:lang="zh-TW">OFBiz: @component-resource-name@</value>
     </property>
     <property key="@component-resource-name@CompanySubtitle">
         <value xml:lang="en">Part of the Apache OFBiz Family of Open Source 
Software</value>
-        <value xml:lang="it">Un modulo della famiglia di software open source 
Apache OFBiz</value>
-        <value xml:lang="zh">开源软件OFBiz的组成部分</value>
-        <value xml:lang="zh-TW">開源軟體OFBiz的組成部分</value>
     </property>
     <property key="@component-resource-name@ViewPermissionError">
         <value xml:lang="en">You are not allowed to view this page.</value>
-        <value xml:lang="zh">不允许你浏览这个页面。</value>
-        <value xml:lang="zh-TW">不允許您檢視這個頁面.</value>
     </property>
 </resource>

Reply via email to