(ofbiz-framework) 02/05: Improved: Could not find PortalPage with portalPageId [] (OFBIZ-13071)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git

commit 146a20a0f109160e700f74a668c395523f1e1abe
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Sat Apr 27 18:55:16 2024 +0200

    Improved: Could not find PortalPage with portalPageId []  (OFBIZ-13071)
    
    When a spider bot gets to certain non-sense URIs under sfa app (it seems 
only
    for sfa, did not dig further it's non-sense anyway) like discovered in
    trunk demo log today: 
<</sfa/control/setSessionTimeZone?tzId=America/Ensenada>>
    the <<Could not find PortalPage with portalPageId []>> error shows
    
    Then we don't need to clutter the log with useless error information.
    This keeps it ASAP by simply returning the portalPage if it's null.
    
    Conflict handled by hand ModelScreenWidget.java
---
 .../src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java   | 1 -
 1 file changed, 1 deletion(-)

diff --git 
a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
 
b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
index c0ec6a842c..481f9fb9eb 100644
--- 
a/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
+++ 
b/framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
@@ -1899,7 +1899,6 @@ public abstract class ModelScreenWidget extends 
ModelWidget {
             if (portalPage == null) {
                 String errMsg = "Could not find PortalPage with portalPageId 
[" + expandedPortalPageId + "] ";
                 Debug.logError(errMsg, module);
-                throw new RuntimeException(errMsg);
             }
             return portalPage;
         }