This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch trunk in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
commit b607602dabb2127156830cf34b5662ec134f38ac Author: Jacques Le Roux <jacques.le.r...@les7arts.com> AuthorDate: Sun Apr 7 07:29:51 2024 +0200 Improved: Reintroduce groovy-test-suite test case (OFBIZ-12320) Improves the documentation for junit-test-suite and groovy-test-suite I still wonder why Eclipse does not accept groovy-test-suite as a right token and shows this message: Element name 'groovy-test-suite' is invalid. One of the following is expected: - TestCaseTypes Error indicated by: {the schema} with code:junit-test-suite when in https://ofbiz.apache.org/dtds/test-suite.xsd there is no important differences between junit-test-suite and groovy-test-suite definitions --- framework/testtools/dtd/test-suite.xsd | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/framework/testtools/dtd/test-suite.xsd b/framework/testtools/dtd/test-suite.xsd index d5c1e04199..0daed87f13 100644 --- a/framework/testtools/dtd/test-suite.xsd +++ b/framework/testtools/dtd/test-suite.xsd @@ -68,7 +68,12 @@ under the License. </xs:attributeGroup> <xs:element name="junit-test-suite" substitutionGroup="TestCaseTypes"> - <xs:annotation><xs:documentation>Used for JUnit test suites written as a Java class.</xs:documentation></xs:annotation> + <xs:annotation> + <xs:documentation> + Used for JUnit test suites written as a Java class. + This is rather to be used in production + </xs:documentation> + </xs:annotation> <xs:complexType> <xs:attributeGroup ref="attlist.junit-test-suite"/> </xs:complexType> @@ -79,6 +84,7 @@ under the License. <xs:documentation> At minimum should extend the junit.framework.TestCase class. If you want to use a GenericDelegator or LocalDispatcher you should extend the OFBizTestCase class and use the ones provided by it. + This is rather to be used in production </xs:documentation> </xs:annotation> </xs:attribute> @@ -88,6 +94,9 @@ under the License. <xs:annotation> <xs:documentation> Used for JUnit test suites written as a Groovy class. See http://groovy-lang.org/testing.html + This is rather to be used during development and testing + When going to production; for performance reason (compilation), you should use rather use junit-test-suite and move the test file under main and use. + See existing examples. </xs:documentation> </xs:annotation> <xs:complexType> @@ -100,8 +109,12 @@ under the License. <xs:annotation> <xs:documentation> Give the location where is groovy file that contains the test suite. - You can use a flexible url location like + You can use a flexible URL location like component://service/src/test/groovy/org/apache/ofbizservice/test/TestServices.groovy + This is rather to be used during development and testing + When going to production you need to move the test file under main. See existing examples. + When going to production; for performance reason (compilation), you should use rather use junit-test-suite and move the test file under main and use. + See existing examples. </xs:documentation> </xs:annotation> </xs:attribute>