(ofbiz-plugins) branch trunk updated: Improved: Convert FactServices.xml minilang to groovy. (OFBIZ-11030)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git


The following commit(s) were added to refs/heads/trunk by this push:
     new e47086d26 Improved: Convert FactServices.xml minilang to groovy. 
(OFBIZ-11030)
e47086d26 is described below

commit e47086d269c73ca8bafe97a9ec620174bac938ba
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Sat Mar 30 10:57:22 2024 +0100

    Improved: Convert FactServices.xml minilang to groovy. (OFBIZ-11030)
    
    Replaces UtilValidate.isNotEmpty() by Groovy Truth
---
 bi/src/main/groovy/org/apache/ofbiz/bi/FactServices.groovy | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bi/src/main/groovy/org/apache/ofbiz/bi/FactServices.groovy 
b/bi/src/main/groovy/org/apache/ofbiz/bi/FactServices.groovy
index ccb301db8..831cf05cf 100644
--- a/bi/src/main/groovy/org/apache/ofbiz/bi/FactServices.groovy
+++ b/bi/src/main/groovy/org/apache/ofbiz/bi/FactServices.groovy
@@ -271,7 +271,7 @@ Map loadSalesOrderItemFact() {
             }
 
             // conversion of the product id
-            if (UtilValidate.isNotEmpty(orderItem.productId)) {
+            if (orderItem.productId) {
                 inMap = [:]
                 naturalKeyFields = [:]
                 inMap.dimensionEntityName = 'ProductDimension'
@@ -344,7 +344,7 @@ Map loadSalesOrderItemFact() {
         Map convertUomCurrencyMap = [:]
         convertUomCurrencyMap.uomId = orderHeader.currencyUom
         convertUomCurrencyMap.uomIdTo = accPref.baseCurrencyUomId
-        if (UtilValidate.isNotEmpty(orderStatus)) {
+        if (orderStatus) {
             convertUomCurrencyMap.nowDate = orderStatus.statusDatetime
         }
         Map convertResult = run service: 'convertUomCurrency', with: 
convertUomCurrencyMap