This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 197fc156cd Improved: Menu-items of EditGlAcctgTransSubTabBar are 
visible to user with only VIIEW PERMISSIONS (OFBIZ-12916) (#709)
197fc156cd is described below

commit 197fc156cddc9b0a1c392ad1ed5d252885b3c16c
Author: Pierre Smits <pierre.sm...@somonar.com>
AuthorDate: Mon Feb 26 18:01:47 2024 +0100

    Improved: Menu-items of EditGlAcctgTransSubTabBar are visible to user with 
only VIIEW PERMISSIONS (OFBIZ-12916) (#709)
    
    The menu-items of the EditGlAcctgTransSubTabBar with en-US translated labels
    Duplicate Accounting Transaction
    Revert Accounting Transaction
    are visible to a user with only VIEW permissions, like 'auditor'
    This should not be.
    
    modifiied: AccountingMenus.xml
    - added permission conditions to menu-items 
DuplicateAccountiingTransaction, RevertAccountingTransactiion
---
 applications/accounting/widget/AccountingMenus.xml | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/applications/accounting/widget/AccountingMenus.xml 
b/applications/accounting/widget/AccountingMenus.xml
index 10b3f8cc44..89a9cb5a69 100644
--- a/applications/accounting/widget/AccountingMenus.xml
+++ b/applications/accounting/widget/AccountingMenus.xml
@@ -1038,6 +1038,11 @@ under the License.
     </menu>
     <menu name="EditGlAcctgTransSubTabBar" menu-container-style="button-bar 
button-style-2" default-selected-style="selected">
         <menu-item name="DuplicateAccountingTransaction">
+            <condition>
+                <or>
+                    <if-has-permission permission="ACCOUNTING" 
action="_CREATE"/>
+                </or>
+            </condition>
             <link 
text="${uiLabelMap.AccountingDuplicateAccountingTransaction}" 
style="buttontext" target="copyAcctgTransAndEntries">
                 <parameter param-name="revert" value="N"/>
                 <parameter param-name="fromAcctgTransId" 
from-field="acctgTransId"/>
@@ -1045,6 +1050,11 @@ under the License.
             </link>
         </menu-item>
         <menu-item name="RevertAccountingTransaction">
+            <condition>
+                <or>
+                    <if-has-permission permission="ACCOUNTING" 
action="_CREATE"/>
+                </or>
+            </condition>
             <link text="${uiLabelMap.AccountingRevertAccountingTransaction}" 
style="buttontext" target="copyAcctgTransAndEntries">
                 <parameter param-name="revert" value="Y"/>
                 <parameter param-name="fromAcctgTransId" 
from-field="acctgTransId"/>

Reply via email to