This is an automated email from the ASF dual-hosted git repository.
jleroux pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git
The following commit(s) were added to refs/heads/release18.12 by this push:
new 43fd8328bc Improved: Screen Communications in Party should not show
create trigger to user with VIEW permissions (OFBIZ-12891) (#688)
43fd8328bc is described below
commit 43fd8328bc3dcff24e29b839c09cd632e90cb5c8
Author: Pierre Smits <pierre.sm...@somonar.com>
AuthorDate: Tue Feb 6 15:08:27 2024 +0100
Improved: Screen Communications in Party should not show create trigger to
user with VIEW permissions (OFBIZ-12891) (#688)
When accessing
https://demo-trunk.ofbiz.apache.org/partymgr/control/FindCommunicationEvents as
a user with only
VIEW permissions (.e.g. userId = auditor) the action trigger to create a
new communication is shown.
This should not be visible to such a user as it leads to an undesired
effect and diminished user experience.
modified:
- PartyMenus.xml - added permission condition to menu-item 'new' in
CommSubTabBar
---
applications/party/widget/partymgr/PartyMenus.xml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/applications/party/widget/partymgr/PartyMenus.xml
b/applications/party/widget/partymgr/PartyMenus.xml
index c45ca6b77b..d60818c869 100644
--- a/applications/party/widget/partymgr/PartyMenus.xml
+++ b/applications/party/widget/partymgr/PartyMenus.xml
@@ -662,6 +662,11 @@
<menu name="CommSubTabBar" extends="CommonButtonBarMenu"
extends-resource="component://common/widget/CommonMenus.xml">
<menu-item name="new" title="${uiLabelMap.PartyNewCommunication}"
widget-style="buttontext create">
+ <condition>
+ <or>
+ <if-has-permission permission="PARTYMGR" action="_CREATE"/>
+ </or>
+ </condition>
<link target="EditCommunicationEvent"/>
</menu-item>
<menu-item name="reply" title="${uiLabelMap.PartyReply}">
