(ofbiz-framework) branch release18.12 updated: Return error when the userLogin service encounters an error during login. It is now more logical to handle unsuccessful logins appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)

[deepak]

This is an automated email from the ASF dual-hosted git repository.

deepak pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release18.12 by this push:
     new 1dcfa07180 Return error when the userLogin service encounters an error 
during login. It is now more logical to handle unsuccessful logins 
appropriately and not proceed with 'requirePasswordChange' (OFBIZ-12873)
1dcfa07180 is described below

commit 1dcfa071804a5b717b9b579aa44f3a8d39592d55
Author: Deepak Dixit <dee...@apache.org>
AuthorDate: Fri Dec 15 19:44:02 2023 +0530

    Return error when the userLogin service encounters an error during login. 
It is now more logical to handle unsuccessful logins appropriately and not 
proceed with 'requirePasswordChange' (OFBIZ-12873)
---
 .../src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java      | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
index e8c1e61e6a..d6e06351b5 100644
--- 
a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
+++ 
b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginWorker.java
@@ -602,7 +602,7 @@ public class LoginWorker {
             Map<String, String> messageMap = UtilMisc.toMap("errorMessage", 
(String) result.get(ModelService.ERROR_MESSAGE));
             String errMsg = UtilProperties.getMessage(resourceWebapp, 
"loginevents.following_error_occurred_during_login", messageMap, 
UtilHttp.getLocale(request));
             request.setAttribute("_ERROR_MESSAGE_", errMsg);
-            return requirePasswordChange ? "requirePasswordChange" : "error";
+            return "error";
         }
     }