[ofbiz-framework] branch trunk updated: Fixed: Reducing scope of variables in org.apache.ofbiz.base package (OFBIZ-10478)

[jleroux]

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9a419c417c Fixed: Reducing scope of variables in org.apache.ofbiz.base 
package (OFBIZ-10478)
9a419c417c is described below

commit 9a419c417cf134e100dacf10d5dc17ca3a83bb30
Author: Jacques Le Roux <jacques.le.r...@les7arts.com>
AuthorDate: Tue Sep 27 17:12:01 2022 +0200

    Fixed: Reducing scope of variables in org.apache.ofbiz.base package 
(OFBIZ-10478)
    
    Reverts
    - public static Map<String, Object> testService(
    + private static Map<String, Object> testService(
    
    This was the real (and AFAIK only) error:
    |W| [JUNIT (error)] - testBasicJavaInvocation :
    org.apache.ofbiz.service.GenericServiceException: Service [testScv]
    specified Java method (invoke attribute) does not exist
    (org.apache.ofbiz.common.CommonServices.testService(...
    [..]
    Caused by: java.lang.NoSuchMethodException:
    org.apache.ofbiz.common.CommonServices.testService(...
            at java.lang.Class.getMethod(Class.java:2108) ~[?:?]
            at 
org.apache.ofbiz.service.engine.StandardJavaEngine.serviceInvoker(...
    
    I think this has no been tested with integration test
---
 .../common/src/main/java/org/apache/ofbiz/common/CommonServices.java    | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git 
a/framework/common/src/main/java/org/apache/ofbiz/common/CommonServices.java 
b/framework/common/src/main/java/org/apache/ofbiz/common/CommonServices.java
index cbab226aec..c84b74be02 100644
--- a/framework/common/src/main/java/org/apache/ofbiz/common/CommonServices.java
+++ b/framework/common/src/main/java/org/apache/ofbiz/common/CommonServices.java
@@ -79,7 +79,7 @@ public class CommonServices {
      *@param context Map containing the input parameters
      *@return Map with the result of the service, the output parameters
      */
-    private static Map<String, Object> testService(DispatchContext dctx, 
Map<String, ?> context) {
+    public static Map<String, Object> testService(DispatchContext dctx, 
Map<String, ?> context) {
         Map<String, Object> response = ServiceUtil.returnSuccess();
 
         if (!context.isEmpty()) {